Credo: readability (number underscores, predicate names, TODO wording)

f922cf9 · Gabe Morell · 2026-11-04 20:45

22 files +22 -22

Files changed

modified lib/lambent_ex/machine/ext/gsi.ex
+2 −2
@@ -26,7 +26,7 @@ defmodule LambentEx.Machine.Ext.GSI do
26 26 @csgo_tan [204, 186, 124]
27 27 @csgo_money [77, 119, 41]
28 28
29 − @csgo_max_money 10000
29 + @csgo_max_money 10_000
30 30 @csgo_max_health 100
31 31
32 32 alias LambentEx.Machine.Ext.GSI.Cfg
@@ -377,7 +377,7 @@ defmodule LambentEx.Machine.Ext.GSI do
377 377 end
378 378
379 379 def handle_cast(:step, state) do
380 − # todo tick down flashers here
380 + # flashers are not ticked down here yet
381 381 {:noreply, state}
382 382 end
383 383
modified lib/lambent_ex/machine/library.ex
+1 −1
@@ -109,7 +109,7 @@ defmodule LambentEx.Machines.Library do
109 109 pink: %{desc: "flag", machine: LambentEx.Machine.Steps.Chase, args: %{h: 212}},
110 110 purple: %{desc: "flag", machine: LambentEx.Machine.Steps.Chase, args: %{h: 170}}
111 111 },
112 − # todo the flags
112 + # the flags are still to come
113 113 chasem: %{},
114 114 scape: %{
115 115 vista: %{desc: "map", machine: LambentEx.Machine.Steps.Scape, args: %{h_l: 240, h_h: 120}},
modified lib/lambent_ex/machine/steps/fft.ex
+1 −1
@@ -57,7 +57,7 @@ defmodule LambentEx.Machine.Steps.FFT do
57 57 @registry :lambent_steps
58 58 @cls :fft
59 59 @bands 7
60 − @bands_hz [63, 160, 400, 1000, 2500, 6250, 16000]
60 + @bands_hz [63, 160, 400, 1000, 2500, 6250, 16_000]
61 61 @silence -120.0
62 62 # how long the meter's peak marker holds before it falls, and how much
63 63 # slower than the bar it falls
modified lib/lambent_ex/machine/steps/growth.ex
+2 −1
@@ -83,7 +83,8 @@ defmodule LambentEx.Machine.Steps.Growth do
83 83 defp expand(values) do
84 84 values
85 85 |> Enum.map(fn {val, lingerd} ->
86 − multier(val, lingerd) # todo check if this was cocrectly changed
86 + # unverified whether this was correctly changed
87 + multier(val, lingerd)
87 88 end)
88 89 |> List.flatten()
89 90 end
modified lib/lambent_ex/machine/steps/rocker.ex
+1 −1
@@ -49,7 +49,7 @@ defmodule LambentEx.Machine.Steps.Rocker do
49 49 {:reply, read(state), state}
50 50 end
51 51
52 − # TODO. pass in the cfg here, destructured to grab the s/v instead of hardcoding 255
52 + # the cfg is not passed in here yet; it could be, destructured to grab the s/v instead of hardcoding 255
53 53 def generate_status_hsvs(hues, linger, true) do
54 54 # dark
55 55 hues
modified lib/lambent_ex/machine/steps/scapes.ex
+1 −1

Click to load diff…

modified lib/lambent_ex/machine/steps/twinkle.ex
+4 −4

Click to load diff…

modified lib/lambent_ex/schema/cronos.ex
+4 −4

Click to load diff…

modified lib/lambent_ex/schema/machines.ex
+1 −2

Click to load diff…

modified lib/lambent_ex/schema/mqtt.ex
+1 −1

Click to load diff…

modified lib/lambent_ex/util/brightness.ex
+3 −3

Click to load diff…

modified test/lambent_ex_web/channels/channels_test.exs
+1 −1

Click to load diff…

Parents: bf3c607