neiam
/gitgud
Git Gud
public · Issues · Pulls · Labels · Forks · Compare · Actions success · Badges · Packages
⭐
1
Log in to mark this repository.
git-HTTP: remove temporary authz diagnostic log
bc2e7a7 · gmorell · 2026-06-26 01:58
Files changed
modified
lib/git_gud_web/plugs/git_smart_http.ex
+1
−15
@@ -188,17 +188,7 @@ defmodule GitGudWeb.Plugs.GitSmartHttp do
| 188 | 188 | defp authorize(conn, %Repository{visibility: "public"} = _repo, @upload_pack), do: {:ok, conn} |
| 189 | 189 | |
| 190 | 190 | defp authorize(conn, %Repository{} = repo, service) do |
| 191 | − principal = authenticate(conn) | |
| 192 | − | |
| 193 | − require Logger | |
| 194 | − | |
| 195 | − Logger.info( | |
| 196 | − "git-http authz repo=#{repo.id}/#{repo.visibility} svc=#{service} " <> | |
| 197 | − "auth=#{conn |> get_req_header("authorization") |> List.first("ABSENT") |> String.slice(0, 14)} " <> | |
| 198 | − "-> #{principal_tag(principal)}" | |
| 199 | − ) | |
| 200 | − | |
| 201 | − case principal do | |
| 191 | + case authenticate(conn) do | |
| 202 | 192 | {:user, user} -> |
| 203 | 193 | if can?(user, repo, service), |
| 204 | 194 | do: {:ok, assign(conn, :git_pusher_id, user.id)}, |
@@ -217,10 +207,6 @@ defmodule GitGudWeb.Plugs.GitSmartHttp do
| 217 | 207 | end |
| 218 | 208 | end |
| 219 | 209 | |
| 220 | − defp principal_tag({:user, u}), do: "user:#{u.id}" | |
| 221 | − defp principal_tag({:job, pid}), do: "job:pid=#{pid}" | |
| 222 | − defp principal_tag(:error), do: "none" | |
| 223 | − | |
| 224 | 210 | # Resolve Basic-auth credentials to a principal: |
| 225 | 211 | # {:user, %User{}} — forge password OR a Personal Access Token |
| 226 | 212 | # {:job, repo_id} — a per-job RunnerJwt |
Parents: e4d412b