Fix CI (don't use 26.2.5 on Windows; be strict when comparing versions) (#299)

ee8d6d1 · Paulo F. Oliveira · 2024-07-17 00:52

2 files +15 -8

Files changed

modified .github/workflows/windows.yml
+1 −1
@@ -44,7 +44,7 @@ jobs:
44 44 - otp-version: '24.0.2'
45 45 rebar3-version: '3.16'
46 46 os: 'windows-2019'
47 - otp-version: '26.2.5'
47 + - otp-version: '26.1'
48 48 rebar3-version: 'nightly'
49 49 os: 'windows-2019'
50 50 - otp-version: '23.0'
modified test/setup-beam.test.js
+14 −7
@@ -183,15 +183,17 @@ async function testOTPVersions() {
183 183 expected = 'maint-26'
184 184 got = await setupBeam.getOTPVersion(spec, osVersion)
185 185 assert.deepStrictEqual(got, expected)
186
187 186 simulateInput('version-type', before)
187 +
188 + before = simulateInput('version-type', 'strict')
188 189 spec = '27.0'
189 190 osVersion = 'ubuntu-24.04'
190 191 expected = 'OTP-27.0'
191 192 got = await setupBeam.getOTPVersion(spec, osVersion)
192 193 assert.deepStrictEqual(got, expected)
193
194 194 simulateInput('version-type', before)
195 +
196 + before = simulateInput('version-type', 'strict')
195 197 spec = '25.3.2.1'
196 198 osVersion = 'ubuntu-20.04'
197 199 expected = 'OTP-25.3.2.1'
@@ -308,15 +310,17 @@ async function testLinuxARM64OTPVersions() {
308 310 expected = 'maint-26'
309 311 got = await setupBeam.getOTPVersion(spec, osVersion)
310 312 assert.deepStrictEqual(got, expected)
311
312 313 simulateInput('version-type', before)
314 +
315 + before = simulateInput('version-type', 'strict')
313 316 spec = '27.0'
314 317 osVersion = 'ubuntu-24.04'
315 318 expected = 'OTP-27.0'
316 319 got = await setupBeam.getOTPVersion(spec, osVersion)
317 320 assert.deepStrictEqual(got, expected)
318
319 321 simulateInput('version-type', before)
322 +
323 + before = simulateInput('version-type', 'strict')
320 324 spec = '25.3.2.1'
321 325 osVersion = 'ubuntu-20.04'
322 326 expected = 'OTP-25.3.2.1'
@@ -393,22 +397,24 @@ async function testLinuxAMD64OTPVersions() {
393 397 expected = 'maint-26'
394 398 got = await setupBeam.getOTPVersion(spec, osVersion)
395 399 assert.deepStrictEqual(got, expected)
396
397 400 simulateInput('version-type', before)
401 +
402 + before = simulateInput('version-type', 'strict')
398 403 spec = '27.0'
399 404 osVersion = 'ubuntu-24.04'
400 405 expected = 'OTP-27.0'
401 406 got = await setupBeam.getOTPVersion(spec, osVersion)
402 407 assert.deepStrictEqual(got, expected)
403
404 408 simulateInput('version-type', before)
409 +
410 + before = simulateInput('version-type', 'strict')
405 411 spec = '25.3.2.1'
406 412 osVersion = 'ubuntu-20.04'
407 413 expected = 'OTP-25.3.2.1'
408 414 got = await setupBeam.getOTPVersion(spec, osVersion)
409 415 assert.deepStrictEqual(got, expected)
410
411 416 simulateInput('version-type', before)
417 +
412 418 spec = '19.3.x'
413 419 osVersion = 'ubuntu-16.04'
414 420 expected = 'OTP-19.3.6.13'
@@ -562,6 +568,7 @@ async function testElixirVersions() {
562 568 got = await setupBeam.getElixirVersion(spec, otpVersion)
563 569 assert.deepStrictEqual(got, expected)
564 570 simulateInput('version-type', before)
571 +
565 572 simulateInput('hexpm-mirrors', hexMirrors, { multiline: true })
566 573 }
567 574

Parents: d2ccea2